Open
Conversation
Member
|
@dennym My plan is to integrate auto-running of rubocop here in a few. I'm going to wait until after I get the sql stuff done so I don't have to deal with related merge conflicts until I have everything back on master. |
Contributor
Author
|
Could be pretty pain to get the current codebase clean first :) Just got up yesterday and checked all new notifications in github and saw this painful 2 tabs code. Had to change it. |
Contributor
|
@dennym that's my code, sorry :) I come from an obscure ruby background where 4 space tabs were the standard in the codebase and I've continued this bad habit for 10 years now :) I've switched my sublime's tab settings to 2 spaces so it shouldn't happen in future PRs from me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe rubocop should be used and also required by CI for green to have some nice unified styling. And not some random patched worked code base.